[skip-changelog] Some integration test refactorings #1911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make much sense to keep it separate in a different library
cmaglie
added
type: enhancement
cmaglie
force-pushed
the
refactor_testsuite
branch
from
3be00a2 to
0c8938e
Compare
Codecov ReportBase: 36.65% // Head: 36.84% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1911 +/- ##
==========================================
+ Coverage 36.65% 36.84% +0.18%
==========================================
Files 231 234 +3
Lines 19683 19758 +75
==========================================
+ Hits 7215 7280 +65
- Misses 11640 11648 +8
- Partials 828 830 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MatteoPologruto
approved these changes
Oct 10, 2022
umbynos
changed the title
umbynos
approved these changes
Oct 10, 2022
Co-authored-by: MatteoPologruto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
go.bug.st/testsuitehas been integrated into the repo: it doesn't make much sense to have it separated in a different library. We may possibly extract the most useful function in the future if we deem it useful.SharedDirobject to share directories between tests. The shared directory is locked before use and must be unlocked after use. TheSharedDirobject providesLockandUnlockmethods to do so.What is the current behavior?
No changes in behavior
What is the new behavior?
No changes in behavior
Does this PR introduce a breaking change, and is titled accordingly?
No